Open
Conversation
I wasn't 100% sure based on the existing docs whether this was intended to be analagous to toHour, toMinute, etc, or if it just converted to posix time in seconds. In hindsight, the latter wouldn't have made much sense, but I was thrown by the facts that: 1. All of the other functions which return a value in a range like this say "From 0 to ..", but this one doesn't. 2. The examples don't disambiguate this. So this patch makes minor improvements to the docs, including the range for consistency and adding another example that disambiguates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't 100% sure based on the existing docs whether this was
intended to be analagous to toHour, toMinute, etc, or if it just
converted to posix time in seconds. In hindsight, the latter wouldn't
have made much sense, but I was thrown by the facts that:
say "From 0 to ..", but this one doesn't.
So this patch makes minor improvements to the docs, including the range
for consistency and adding another example that disambiguates.